Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WASI "preview0" in wasmtime-wasi #7548

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

alexcrichton
Copy link
Member

This commit implements the wasi_unstable module, sometimes referred to as "preview0", in the wasmtime-wasi crate. Previously this was only implemented by the wasi-common crate but now this is implemented for both meaning that the switch to preview2 won't lose this functionality.

The preview0 WITX files are vendored like the preview1 files and the implementation of preview0 is exclusively implemented by delegating to the preview1 implementation.

@alexcrichton alexcrichton requested a review from a team as a code owner November 15, 2023 22:32
@alexcrichton alexcrichton requested review from fitzgen and removed request for a team November 15, 2023 22:32
@github-actions github-actions bot added the wasi Issues pertaining to WASI label Nov 15, 2023
Copy link
Contributor

@pchickey pchickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foo.diff should be deleted, otherwise lgtm

This commit implements the `wasi_unstable` module, sometimes referred to
as "preview0", in the `wasmtime-wasi` crate. Previously this was only
implemented by the `wasi-common` crate but now this is implemented for
both meaning that the switch to preview2 won't lose this functionality.

The preview0 WITX files are vendored like the preview1 files and the
implementation of preview0 is exclusively implemented by delegating to
the preview1 implementation.
@alexcrichton alexcrichton added this pull request to the merge queue Nov 16, 2023
Merged via the queue into bytecodealliance:main with commit 49c32d2 Nov 16, 2023
18 checks passed
@alexcrichton alexcrichton deleted the wasi-unstable branch November 16, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasi Issues pertaining to WASI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants